Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dockerfile for developing ROFL #2063

Merged
merged 2 commits into from
Dec 20, 2024
Merged

Add Dockerfile for developing ROFL #2063

merged 2 commits into from
Dec 20, 2024

Conversation

jberci
Copy link
Contributor

@jberci jberci commented Nov 15, 2024

No description provided.

Copy link

netlify bot commented Nov 15, 2024

Deploy Preview for oasisprotocol-oasis-sdk failed.

Name Link
🔨 Latest commit 53b2d9d
🔍 Latest deploy log https://app.netlify.com/sites/oasisprotocol-oasis-sdk/deploys/676439afcead3d0008a7d024

@jberci jberci requested a review from matevz November 15, 2024 09:34
@jberci jberci marked this pull request as ready for review November 15, 2024 09:34
@jberci jberci force-pushed the jberci/feature/macos-docker branch from 0cf620f to 0554b1b Compare November 15, 2024 10:42
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll make another pass once Oasis CLI 0.10.3+ is released.

docs/rofl/prerequisites.md Show resolved Hide resolved
@matevz matevz added the blocked label Nov 15, 2024
@@ -0,0 +1,9 @@
FROM ghcr.io/oasisprotocol/oasis-core-dev:stable-24.3.x AS oasis-core-dev

ARG OASIS_CLI_VERSION=0.10.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docs/rofl/prerequisites.md Outdated Show resolved Hide resolved
@jberci jberci force-pushed the jberci/feature/macos-docker branch 2 times, most recently from dfe9879 to 5ffd4cd Compare November 19, 2024 14:52
@matevz matevz removed the blocked label Nov 21, 2024
@jberci jberci force-pushed the jberci/feature/macos-docker branch from 5ffd4cd to 4e6fcc3 Compare November 25, 2024 16:46
@jberci jberci force-pushed the jberci/feature/macos-docker branch from 4e6fcc3 to 2f9396e Compare December 3, 2024 14:44
@CedarMist
Copy link
Member

I noticed I needed ENV RUSTFLAGS="-C target-feature=+aes,+ssse3" in the Dockerfile otherwise deoxysii failed to build, unless I specified it manually when building.

Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the issues. Otherwise lgtm. Merge oasisprotocol/docs#1042 first to unblock the CI.

docs/rofl/app.mdx Outdated Show resolved Hide resolved
docs/rofl/app.mdx Outdated Show resolved Hide resolved
docker/rofl-dev/Dockerfile Show resolved Hide resolved
@jberci jberci force-pushed the jberci/feature/macos-docker branch from 2f9396e to 2b1a680 Compare December 19, 2024 14:58
@jberci jberci force-pushed the jberci/feature/macos-docker branch from 2b1a680 to 53b2d9d Compare December 19, 2024 15:20
@jberci jberci merged commit 6e253f9 into main Dec 20, 2024
26 of 27 checks passed
@jberci jberci deleted the jberci/feature/macos-docker branch December 20, 2024 12:08
github-actions bot added a commit that referenced this pull request Dec 20, 2024
…berci/feature/macos-docker

Add Dockerfile for developing ROFL 6e253f9
github-actions bot added a commit that referenced this pull request Dec 20, 2024
…/jberci/feature/macos-docker

Add Dockerfile for developing ROFL 6e253f9
github-actions bot added a commit to OasisUnofficial/oasis-sdk that referenced this pull request Dec 20, 2024
…sisprotocol/jberci/feature/macos-docker

Add Dockerfile for developing ROFL 6e253f9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants